On Thu, Aug 07, 2008 at 09:42:29PM +0000, Junio C Hamano wrote: > Brandon Casey <casey@xxxxxxxxxxxxxxx> writes: > > > Brandon Casey wrote: > >> Robin H. Johnson wrote: > >>> In a 64-bit userland, big-endian environment, the parser gets integers > >>> wrong. > >> > >> There is a fix on master. Can you try that out? > >> Unfortunately, looks like it did not make it into 1.5.6.5 > > > > Also, just so you know, it is test-parse-options.c that is broken, not > > the parsing code. So, the rest of git should be using an int with > > OPT_INTEGER() and should operate correctly. > > Yup, that is why it is not on 'maint' --- but somebody should audit the > parse_options() users in the real programs to make sure that there is no > similar breakages, namely, giving a pointer to long to OPT_INTEGER(). Well FWIW I'll probably write some __GNUC__ guarded glue using __builtin_types_compatible and friends to ensure we're not passing crap to the OPT_* macros. I just didn't have time to yet. -- ·O· Pierre Habouzit ··O madcoder@xxxxxxxxxx OOO http://www.madism.org
Attachment:
pgpEjJaY4B0dY.pgp
Description: PGP signature
