Brandon Casey <casey@xxxxxxxxxxxxxxx> writes: > Junio C Hamano wrote: >> Brandon Casey <casey@xxxxxxxxxxxxxxx> writes: >> >>> Use double quotes to protect against paths which may contain spaces. >>> ... >>> + echo ' mkdir -p "$(instdir_SQ)"' >> $@ >> >> Is this sufficient? We seem to apply double-sq when writing shell >> scriptlet in GIT-BUILD-OPTIONS from the main Makefile, and I suspect you >> would need to do something similar. > > It seems to be sufficient. The double quotes survived into my perl.mak file > and the two perl modules were installed correctly when I supplied a prefix > with spaces. Is there something else to be concerned about? I think the generic way GIT-BUILD-OPTIONS writing is done covers cases where the installation directory has funnies other than whitespace, e.g. double quotes. Is your 'echo "$(instdir_SQ)"' sufficient? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
