We currently check only for '-f' but we need to have read permissions as well. And help files don't need the execution bit set. Signed-off-by: Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx> --- Makefile | 2 +- tg.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 238d07d..f9dbe6e 100644 --- a/Makefile +++ b/Makefile @@ -35,7 +35,7 @@ install:: all install -d -m 755 "$(hooksdir)" install $(hooks_out) "$(hooksdir)" install -d -m 755 "$(sharedir)" - install $(help_out) "$(sharedir)" + install -m 644 $(help_out) "$(sharedir)" clean:: rm -f tg $(commands_out) $(hooks_out) $(help_out) diff --git a/tg.sh b/tg.sh index 03a392b..edac006 100644 --- a/tg.sh +++ b/tg.sh @@ -154,7 +154,7 @@ do_help() if [ -z "$1" ] ; then echo "TopGit v0.1 - A different patch queue manager" echo "Usage: tg (create|delete|info|patch|summary|update|help) ..." - elif [ -f "@sharedir@/tg-$1.txt" ] ; then + elif [ -f "@sharedir@/tg-$1.txt" -a -r "@sharedir@/tg-$1.txt" ] ; then cat "@sharedir@/tg-$1.txt" else echo "`basename $0`: no help for $1" 1>&2 -- tg: (e311d15..) t/check-read-permissions-of-help-files (depends on: master) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
