Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> writes: > On Mon, 4 Aug 2008, Junio C Hamano wrote: >> >> I started to revisit this issue and patched "git update-index --add" >> and "git add" so far. Patches follow. > > Patches look good to me, but did you check the performance impact? > > The rewritten 'has_symlink_leading_path()' should do ok, but it migth > still be a huge performance downside to check all the paths for things > like "git add -u". Not yet. I think this is a necessary "correctness" thing to do regardless of the performance impact, and adding the logic to stop at submodule boundary (aka gitlinks) should come before optimization. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
