On Mon, Aug 04, 2008 at 01:05:56AM -0700, Junio C Hamano wrote: > Petr Baudis <pasky@xxxxxxx> writes: > > > The hash_and_insert_object() and cat_blob() helpers were using > > an incorrect slice-from-ref Perl syntax. This patch fixes that up > > in the _close_*() helpers and make the _open_*() helpers use the > > same syntax for consistnecy. > > > > Signed-off-by: Petr Baudis <pasky@xxxxxxx> > > --- > > > > Wow, the command_bidi_pipe API really is dirty. Of course, it is > > my fault as anyone's since I didn't get around to review the patches > > introducing it. > > Sorry, delete is still broken with your patch, isn't it? Oh, right - I forgot that one and it didn't occur to me to test this part. > The earlier patch from Abhijit Menon-Sen does this properly for > close_hash_and_insert and close_cat_blob, which I've queued already. Abhijit, can you please tag your Git.pm patches so that I actually have a chance to see and review it? Thanks, Petr "Pasky" Baudis -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
