When a 'url.*.insteadOf' rule in the superrepo matches a submodule URL, we should rewrite the submodule URL accordingly, so that we don't request the submodule from location that is inaccessible (or unwanted by the user for some other reason). Signed-off-by: Johan Herland <johan@xxxxxxxxxxx> --- git-submodule.sh | 6 ++++++ t/t7400-submodule-basic.sh | 2 +- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/git-submodule.sh b/git-submodule.sh index b40f876..ea2aa3b 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -96,6 +96,12 @@ module_clone() test -e "$path" && die "A file already exist at path '$path'" + # The user may have added url.*.insteadOf rules intending to rewrite + # submodule URLs. We must explicitly do this rewrite before calling + # 'git clone', since 'git clone' will not consult the super-repo + # config and thus never see any url.*.insteadOf rules placed therein. + url=$(git config --rewrite-url "$url") + git-clone -n "$url" "$path" || die "Clone of '$url' into submodule path '$path' failed" } diff --git a/t/t7400-submodule-basic.sh b/t/t7400-submodule-basic.sh index bafc46c..9c56de2 100755 --- a/t/t7400-submodule-basic.sh +++ b/t/t7400-submodule-basic.sh @@ -209,7 +209,7 @@ test_expect_success 'update --init' ' ' -test_expect_failure 'update --init with url.*.insteadOf' ' +test_expect_success 'update --init with url.*.insteadOf' ' rm -rf init && git config -f .gitmodules submodule.example.url "http://example.com/init2"; && -- 1.6.0.rc1.34.g0fe8c -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
