On Sat, Aug 2, 2008 at 3:05 PM, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote:
>
> Hmm. The has_doubledash test seems redundant since we don't do
> anything with args that aren't --foo. Even though git-grep will
> accept a tree-ish and thus completion of __git_refs here may
> make sense.
>
> But that is very much a user question. Do users mostly search a
> file in the current working directory, or do they mostly search
> a tree-ish?
I haven't found myself using grep to search anything but the current
working directory. I wonder whether __git_complete_file would be
better than __git_refs. My issue with __git_complete_file in this
case and also doing completion for 'git mv' is that it falls back to
just __git_refs. Would it be better if it fell back to __git_refs and
ls-tree for HEAD? That way when using completion to get to
Documentation/git-grep.txt, it doesn't also show completions for
Documentation/git-grep.{1,html,xml}.
-Lee
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
