Boyd Lynn Gerber <gerberb@xxxxxxxxx> writes: > On Wed, 30 Jul 2008, Junio C Hamano wrote: >> Aidan Van Dyk <aidan@xxxxxxxxxxx> writes: >> > SCO OpenServer also hides the definitions of (at least) u_short and >> > friends if _XOPEN_SOURCE is defined. >> >> I thought that was covered by 457bb45 (Port to 12 other Platforms., 2008-06-08). > > I thought it was covered as well. > >> Sign-off? >> >> Boyd, does this make any of the earlier symbols you added redundant? > > I have just tried this on 4 OpenServer 6.0 machines fresh installed and I > do not need this added. I am trying to figure out what is different on > his. It appears he is using the exact same version of the compiler as > well. > > My uname -a gives me this... > > SCO_SV tech0 5 6.0.0 i386 > > and the gcc -V gives me the exact same compiler. So I do not know why he > has to have the additional __OPENSERVER__. This does break my OpenServer > 5.0.7 fresh install as well. So I would not use it. What I do not > understand is why the !defined(__USLC__) does not catch it. It should. Thanks for a prompt response. Could you work with Aidan to come up with the optimal solution that does not break anybody? I won't queue this patch until the issue is sorted out. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html