On Jul 30, 2008, at 7:29 AM, Johannes Schindelin wrote:
Hi,
On Tue, 29 Jul 2008, Kevin Ballard wrote:
MIME defines the encapsulation boundary as including the preceding
CRLF (or in
This line will still be too long in git log's output, as well as in
git
shortlog's output. I thought we had a suggestion to use at most 76
characters per line in SubmittingPatches, but apparently we don't.
Good point. I'll send another re-wrapped patch.
The second change is to always write the line termination character
(default: newline) even when using --inline or --attach. This is
simply
to improve the aesthetics of the resulting message. When using --
inline
an email client should render the resulting message identically to
the
non-inline version. And when using --attach this adds a blank line
preceding the attachment in the email, which is visually attractive.
It appears that your patch has one uncontroversial and one
controversial
part, then.
Is this controversial? Nobody's objected so far. My goal with this
change is to make the --inline output render exactly the same as the
default output in a mail client. I can't think of any downside.
-Kevin Ballard
--
Kevin Ballard
http://kevin.sb.org
kevin@xxxxxx
http://www.tildesoft.com
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
