On Jul 30, 2008, at 7:25 AM, Shawn O. Pearce wrote:
Steffen Prohaska <prohaska@xxxxxx> wrote:
Isn't only the computation of sharedir based on gitexecdir wrong?
ifndef sharedir
sharedir := $(dir $(gitexecdir))share
and could be replaced with this (instead of your patch):
ifndef sharedir
+ifeq (git-core,$(notdir $(gitexecdir)))
+ sharedir := $(dir $(patsubst %/,%,$(dir $(gitexecdir))))share
+else
sharedir := $(dir $(gitexecdir))share
endif
+endif
Oh, damn good catch. Thanks.
How about this then? Its your patch above, my message, and me
forging your SOB...
looks good. SOB ok.
Thanks,
Steffen
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
