Hi,
On Sun, 27 Jul 2008, Junio C Hamano wrote:
> Miklos Vajna <vmiklos@xxxxxxxxxxxxxx> writes:
>
> > diff --git a/help.h b/help.h
> > index 0741662..85d3b74 100644
> > --- a/help.h
> > +++ b/help.h
> > @@ -1,7 +1,19 @@
> > #ifndef HELP_H
> > #define HELP_H
> >
> > +struct cmdnames {
> > + int alloc;
> > + int cnt;
> > + struct cmdname {
> > + size_t len;
> > + char name[1];
> > + } **names;
> > +};
>
> I thought we do this kind of thing using FLEX_ARRAY macro. Is there any
> reason its use is not appropriate here?
I think that came up in the previous review round: the "name" member _is_
NUL-terminated, but could have a ".exe" suffix. The "len" member has the
length excluding ".exe".
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
