Hi, On Sat, 26 Jul 2008, Christian Couder wrote: > I suspect this patch may be usefull to simplify my > "bisect: add merge bases check" series and perhaps > also generally usefull. s/usefull/useful/ > diff --git a/builtin-merge-base.c b/builtin-merge-base.c > index 1cb2925..9c41849 100644 > --- a/builtin-merge-base.c > +++ b/builtin-merge-base.c > @@ -2,9 +2,14 @@ > #include "cache.h" > #include "commit.h" > > -static int show_merge_base(struct commit *rev1, struct commit *rev2, int show_all) > +static struct commit *rev1, **prev2; > +static size_t prev2_nr, prev2_alloc; > + > + > +static int show_merge_base(int show_all) > { Changing the arguments to be static variables? NACK! Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html