On 7/25/08, Alex Riesen <raa.lkml@xxxxxxxxx> wrote:
> Nguyen Thai Ngoc Duy, Wed, Jul 23, 2008 16:55:49 +0200:
>
> >
> > +static int no_external_grep;
> > +
>
>
> If you have used direct logic instead of negative, your patch would
> have been simplier and the code would be easier to understand. I.e.:
Point taken.
> + if (!strcmp("--no-external-grep", arg)) {
> + external_grep = 0;
> + continue;
> + }
>
> BTW, how about a config option for this? And maybe --external-grep={yes|no}
I don't need --external-grep=yes now, but that would be good for
testing external grep. About config option, is it really needed?
--
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
