Hi,
On Thu, 24 Jul 2008, Olivier Marin wrote:
> Michele Ballabio a écrit :
> >
> > if (argc == 1)
> > - usage(builtin_verify_tag_usage);
> > + usage_with_options(builtin_verify_tag_usage, options);
>
> It seems this is broken since the C rewrite: "git verify-tag -v" just do
> nothing instead of printing usage message.
>
> Moving the if() after parse_options() call with s/argc == 1/argc == 0/
> should do the trick.
That would be a bugfix. As such, it belongs into a different commit.
Care to provide a patch?
> > - if (!strcmp(argv[i], "-v") || !strcmp(argv[i], "--verbose")) {
> > - verbose = 1;
> > - i++;
> > - }
> > + argc = parse_options(argc, argv, options, builtin_verify_tag_usage, 0);
Why did you quote this?
Ciao,
Dscho
