Johannes Sixt <johannes.sixt@xxxxxxxxxx> writes: > It also fixes 'make install' of git-gui as well (sigh!) by not exporting > gitexecdir - assuming that Shawn applies the git-gui patch. Yeah, this seems to break the install quite badly without git-gui patch. If your PATH does not include the bindir you are installing the freshly built git, then the Makefile in git-gui runs: ifndef gitexecdir gitexecdir := $(shell git --exec-path) endif and miserably fails. We can assume that somebody who builds and installs git-gui as a standalone project already *has* an installed, working git on $PATH, so the above ifndef is Ok, but when git-gui is built as part of git.git tree, we really should avoid triggering that codepath. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
