On Mittwoch, 23. Juli 2008, Junio C Hamano wrote: > Johannes Sixt <johannes.sixt@xxxxxxxxxx> writes: > > On Dienstag, 22. Juli 2008, Johannes Schindelin wrote: > >> On Mon, 21 Jul 2008, Johannes Sixt wrote: > >> > The problem was that argv[0] does not have a path in certain cases. > >> > >> Note that the same holds true for Linux when calling a program that is > >> in the PATH: > > > > Oh, boy! > > > >> I imagine that the proper solution would be to rip out lookup_prog() and > >> use it for non-Windows Git, too. Unless you want to limit the > >> usefulness of your patch series to Windows, that is. > > > > This certainly goes beyond what I am prepared to do. It is not my itch. > > The series is already much longer than I wanted, when there is a much > > simpler solution that solves *my* problem: to set bindir = $(gitexecdir). > > If you are living in the Windows world, perhaps you could record the > installation location in resource somewhere from the installer and look it > up at runtime? Or is it considered a bad practice? Well, looking at value of _pgmptr *is* "look it up at runtime"; no resources or help from the installer are needed. My rant here is more about that I created a *long* patch series only to find out that it does not have enough genericity to solve the same problem (relocatability) on platforms other than Windows - and I don't want to make it even longer. Windows is special enough that *I* could live with a much simpler solution even though it is a bit retro. -- Hannes -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
