Johannes Schindelin, Tue, Jul 22, 2008 22:17:21 +0200: > Hi, > > On Tue, 22 Jul 2008, Alex Riesen wrote: > > > +#ifndef NO_TRUSTABLE_FILEMODE > > if (ce->ce_ctime != (unsigned int) st->st_ctime) > > changed |= CTIME_CHANGED; > > +#endif > > Surely you meant trust_executable_bit instead, right? No. Just what I said: we don't have filemode (like "at all") - so no ctime as well. But maybe you're right, and trust_executable_bit is more flexible. Or maybe both (the #ifdef _and_ trust_executable_bit) and must be used... > Otherwise, if you really want to tell at compile time,I think for clarity > you have to introduce another #define, since NO_TRUSTABLE_FILEMODE > definitely says something different than CTIME_IS_USELESS. I had that at first (NO_DEPENDABLE_CTIME, than IGNORE_CTIME), than deemed it excessive. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
