On Tue, Jul 22, 2008 at 06:44:27PM +0000, Olivier Marin wrote: > From: Olivier Marin <dkr@xxxxxxxxxxx> > > Before this patch, running a git command with a "--foobar=" argument > will set the "foobar" option with a random value and continue. > We should instead, exit with an error if a value is required, or use > the default one if the value is optional. Wrong, --foobar= is the option "foobar" with the argument "" (empty string). as soon as you use the --foobar=... form, that is the "stuck form" for long option, there *is* a value. IOW --foobar= is not the same as --foobar at all. If like you claim, --foobar= pass a "random" value to the option then *this* is a bug, it should pass a pointer to an empty string (IOW a pointer that points to a NUL byte), but I see nothing in the code that would explain what you claim. -- ·O· Pierre Habouzit ··O madcoder@xxxxxxxxxx OOO http://www.madism.org
Attachment:
pgpOIkoxao7qC.pgp
Description: PGP signature
