Jeff King <peff@xxxxxxxx> writes: > On Tue, Jul 22, 2008 at 02:46:04AM -0400, Jeff King wrote: > >> I am tempted by the "order switching" I mentioned, but that would entail >> the git process waiting to clean the pager, during which time it may be >> consuming memory. But maybe that isn't worth worrying about. > > It feels very wrong proposing this during release freeze, but here is > the "pager is child of git" implementation. Another slight worry I have is if the now-parent git process does the right thing when the user kills the pager without viewing the output to the end. git itself will get stuck with write() while the user is reading, and then notice that the pipe does not have any more reader when the pager is killed. This fact itself won't change by swapping the parent-child relationship, but would we get a sensible behaviour after that, or have we been ignoring what happens afterwards only because our exit status has been hidden behind the pager? Running "git log" and killing it by "q" (my pager is "less") makes it exit with 141. I shouldn't worry, if everything is written correctly in the other parts of the system, this swap should not have much ill effect. By the way [2/2] was not signed-off. Just forgotten? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
