"Philippe Bruhat (BooK)" <book@xxxxxxxx> writes: > When using git-rebase, author fields containing a ')' at the last > position had the close-parens character incorrectly removed > because the From: parser incorrectly matched it as > > user@host (User Name) > > (removing parentheses), instead of > > User Name (me) <user@host> > > Signed-off-by: Philippe Bruhat (BooK) <book@xxxxxxxx> Hmm, tests? By the way, that second form parses like this: mailbox = name-addr = display-name angle-addr = "User Name (me) <user@host>" display-name = phrase = "User Name" angle-addr = CFWS "<" addr-spec ">" = "(me) <user@host>" So strictly speaking, shouldn't we be stripping the whole (me) as garbage? It is not even part of the display-name but is a whitespace equivalent comment. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html