Re: [PATCH] Fix git-shell build error when NO_SETENV is defined

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 21 Jul 2008, Stephan Beyer wrote:

> If NO_SETENV is defined, git-shell could not be built.
> 
> Thanks to SungHyun Nam for the hint.
> 
> Signed-off-by: Stephan Beyer <s-beyer@xxxxxxx>
> ---
> 
> This was my mistake. I haven't tested with several build options.
> Now I've tested with
> 	NO_SETENV=1 NO_EXPAT=1 NO_MEMMEM=1 NO_STRTOUMAX=1 NO_MKDTEMP=1
> 	NO_SYS_SELECT_H=1 NO_SYMLINK_HEAD=1
> and compat/setenv.o seems to be the only one that was missing.

Funny.  It was not 24 hours ago that Hannes reported a related issue.  And 
he was testing with different options.

His fix to include COMPAT_OBJECTS made much more sense, too, than to pick 
selectively a file here and a file there and then hoping that you catch 
all.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux