Hi, On Sat, 19 Jul 2008, Junio C Hamano wrote: > diff --git a/builtin-add.c b/builtin-add.c > index bf13aa3..9b2ee8c 100644 > --- a/builtin-add.c > +++ b/builtin-add.c > [...] > + /* > + * If we are adding new files, we need to scan the working > + * tree to find the ones that match pathspecs; this needs > + * to be done before we read the index. > + */ This comment left me scratching my head. While I do see a breakage when reading the index first, I had the impression that it should not. I can only imagine that the other users of read_directory() depend on some funny interaction between the index and treat_directory(). Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html