Florian KKKberle <FloriansKarten@xxxxxx> wrote: > I had a short look at the files and noticed that the inner "if (help) {" > is unnecessary: > > + if (help) { > + System.err.print("jgit "); > + System.err.print(commandName); > + clp.printSingleLineUsage(System.err); > + System.err.println(); > + > + if (help) { Gaaah. Good catch, thanks. I copied and pasted that block from the global option parser to the per-command parser, and then refactored it a little and missed removing this unnecessary inner if test. I'll fix with a rebase. -- Shawn. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html