Hi, On Fri, 18 Jul 2008, Dmitry Potapov wrote: > On Fri, Jul 18, 2008 at 03:04:30AM +0200, Stephan Beyer wrote: > > Commit 5b8e6f85 introduced stubs for three functions that make no > > sense for git-shell. But those stubs defined libgit.a functions a > > second time so that a linker can complain. > > > > Now git-shell is only linked to a subset of libgit.a. > > > > Signed-off-by: Stephan Beyer <s-beyer@xxxxxxx> > > I agree, it is probably better to specify explicitly what files to link > for git-shell if we want to keep it small and avoid the problem with > some linkers. It is also more elegant in general, as it does not play tricks to do what we want, but it does explicitely what we want. FWIW I only removed almost the exact launch_editor() patch Stephan posted from my personal Git fork because of this trickery (which I did not have the time to fix). Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
