Hi, On Wed, 16 Jul 2008, Sverre Rabbelier wrote: > On Wed, Jul 16, 2008 at 3:31 AM, SungHyun Nam <goweol@xxxxxxxxx> wrote: > > > > Signed-off-by: SungHyun Nam <goweol@xxxxxxxxx> > > --- > > t/Makefile | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/t/Makefile b/t/Makefile > > index a778865..0d65ced 100644 > > --- a/t/Makefile > > +++ b/t/Makefile > > @@ -26,7 +26,7 @@ clean: > > $(RM) -r 'trash directory' test-results > > > > aggregate-results: > > - ./aggregate-results.sh test-results/t*-* > > + '$(SHELL_PATH_SQ)' ./aggregate-results.sh test-results/t*-* > > > > # we can test NO_OPTIMIZE_COMMITS independently of LC_ALL > > full-svn-test: > > -- > > 1.5.6.3.350.g6c11a > > It is not clear to me what this patch does, there is no justification > in the commit msg either. Instead you say what is being done, which we > can see from the commit diff. Please clarify? My _guess_ is that this comes from a platform like Solaris, where /bin/sh is not even POSIX. And I'd expect aggregate-results to use some non-trivial shell constructs which break with such a broken shell. But I completely agree, the commit message desperately wants to include some justification. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
