Re: [PATCH] Only use GIT_CONFIG in "git config", not other programs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 30, 2008 at 9:37 AM, Daniel Barkalow <barkalow@xxxxxxxxxxxx> wrote:
> @@ -611,31 +613,28 @@ int git_config(config_fn_t fn, void *data)
>  {
>        int ret = 0;
>        char *repo_config = NULL;
> -       const char *home = NULL, *filename;
> +       const char *home = NULL;
>
>        /* $GIT_CONFIG makes git read _only_ the given config file,
>         * $GIT_CONFIG_LOCAL will make it process it in addition to the
>         * global config file, the same way it would the per-repository
>         * config file otherwise. */

I noticed today while looking at config.c (because of the 'git config
oddity' thread) that this reference to GIT_CONFIG_LOCAL was not
removed? On latest next:
$ grep GIT_CONFIG_LOCAL *
config.c:	 * $GIT_CONFIG_LOCAL will make it process it in addition to the
git-svn:		my $file = $ENV{GIT_CONFIG} || $ENV{GIT_CONFIG_LOCAL} ||
git-svn.perl:		my $file = $ENV{GIT_CONFIG} || $ENV{GIT_CONFIG_LOCAL} ||

I doubt that this stray comment will hurt anyone, but it's probably
nicer not to let cruft like this accumulate, I think?

-- 
Cheers,

Sverre Rabbelier
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux