Teemu Likonen <tlikonen@xxxxxx> wrote:
> Add the following long options to be completed with 'git send-email':
>
> --bcc --cc --cc-cmd --chain-reply-to --compose --dry-run
> --envelope-sender --from --identity --in-reply-to
> --no-chain-reply-to --no-signed-off-by-cc --no-suppress-from
> --no-thread --quiet --signed-off-by-cc --smtp-pass --smtp-server
> --smtp-server-port --smtp-ssl --smtp-user --subject --suppress-cc
> --suppress-from --thread --to
>
> Short ones like --to and --cc are not usable for actual completion
> because of the shortness itself and because there are longer ones which
> start with same letters (--thread, --compose). It's still useful to have
> these shorter options _listed_ when user presses TAB key after typing
> two dashes. It gives user an idea what options are available (and --to
> and --cc are probably the most commonly used).
>
> Signed-off-by: Teemu Likonen <tlikonen@xxxxxx>
Acked-by: Shawn O. Pearce <spearce@xxxxxxxxxxx>
Thanks for the quick reply cleaning up the minor details. :)
> Shawn O. Pearce wrote (2008-07-15 04:38 +0000):
>
> > Don't use __git_complete_file here. As far as I remember,
> > git-send-email does not accept "origin/maint:some.patch" as an email
> > to extract from Git prior to sending. It looks for files in the local
> > filesystem. So you want standard bash completion for anything not
> > starting with --.
> >
> > Just use COMPREPLY=() at the end. See _git_am for an example.
>
> Done. And thanks.
>
> > > +complete -o default -o nospace -F _git_send_email git-send-email
>
> > Hmm. With dash form commands gone in 1.6 we should remove these.
> >
> > But I suspect this completion patch could be shipped in the next 1.5.6
> > maint release as its really quite trivial. Junio, any comment on
> > that?
>
> This is a for-1.6 version so the completion for dashed command
> (git-send-email) is dropped. I see Shawn already sent a patch which
> drops all those.
>
>
>
> contrib/completion/git-completion.bash | 19 +++++++++++++++++++
> 1 files changed, 19 insertions(+), 0 deletions(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d268e6f..48ebbf7 100755
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -905,6 +905,24 @@ _git_rebase ()
> __gitcomp "$(__git_refs)"
> }
>
> +_git_send_email ()
> +{
> + local cur="${COMP_WORDS[COMP_CWORD]}"
> + case "$cur" in
> + --*)
> + __gitcomp "--bcc --cc --cc-cmd --chain-reply-to --compose
> + --dry-run --envelope-sender --from --identity
> + --in-reply-to --no-chain-reply-to --no-signed-off-by-cc
> + --no-suppress-from --no-thread --quiet
> + --signed-off-by-cc --smtp-pass --smtp-server
> + --smtp-server-port --smtp-ssl --smtp-user --subject
> + --suppress-cc --suppress-from --thread --to"
> + return
> + ;;
> + esac
> + COMPREPLY=()
> +}
> +
> _git_config ()
> {
> local cur="${COMP_WORDS[COMP_CWORD]}"
> @@ -1376,6 +1394,7 @@ _git ()
> rebase) _git_rebase ;;
> remote) _git_remote ;;
> reset) _git_reset ;;
> + send-email) _git_send_email ;;
> shortlog) _git_shortlog ;;
> show) _git_show ;;
> show-branch) _git_log ;;
> --
> 1.5.6.3.316.g01fc
>
--
Shawn.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
