Re: [PATCH 3/4] Convert git_id() to the new id format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2008-07-13 12:40:48 +0100, Catalin Marinas wrote:

> @@ -67,8 +64,8 @@ def func(parser, options, args):
>                  rev = strip_suffix('/', rev)
>                  if rev.endswith('/'):
>                      rev = strip_suffix('/', rev)
> -                rev1 = rev + '//bottom'
> -                rev2 = rev + '//top'
> +                rev1 = rev + 'HEAD^'
> +                rev2 = rev + 'HEAD'

This looks bogus. You probably want to s/HEAD// here.

I guess the test suite doesn't cover this? :-(

-- 
Karl Hasselström, kha@xxxxxxxxxxx
      www.treskal.com/kalle
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux