Re: [PATCH] Fixed text file auto-detection: treat EOF character 032 at the end of file as printable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Jul 11, 2008, at 8:42 PM, Johannes Schindelin wrote:

On Fri, 11 Jul 2008, Steffen Prohaska wrote:

From: Dmitry Kakurin <Dmitry.Kakurin@xxxxxxxxx>

Signed-off-by: Dmitry Kakurin <Dmitry.Kakurin@xxxxxxxxx>
Signed-off-by: Steffen Prohaska <prohaska@xxxxxx>
---
convert.c |    4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/convert.c b/convert.c
index 352b69d..78efed8 100644
--- a/convert.c
+++ b/convert.c
@@ -61,6 +61,10 @@ static void gather_stats(const char *buf, unsigned long size, struct text_stat *
		else
			stats->printable++;
	}
+
+ /* If file ends with EOF then don't count this EOF as non- printable. */
+	if (size >= 1 && buf[size-1] == '\032')
+		stats->nonprintable--;

This is one of the things that are very specific to Windows and should not
affect other people.

Does this mean you are opposed to this change?

Junio thinks that "the intention of this change is good" [1].  Hence,
I cleaned up the style and re-send the patch.

[1] http://article.gmane.org/gmane.comp.version-control.git/87122

	Steffen

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux