On Wed, 9 Jul 2008, Junio C Hamano wrote: > > A hack like the one attached below would make it "work" but it is too > ugly. Probably we need to bite the bullet and rename ours not to > collide, so that external library headers can safely include <ctype.h>. We should be able to safely include <ctype.h> as-is. It should just happen _before_ including git-compat-util.h. That's why git-compat-util.h does all those #undef's - exactly because ctype.h does get included on various systems by various header files when git-compat-util.h includes all those other files. So the problem with Robert's patch is that it happens after "cache.h". The system headers should be included at the top of git-compat-util.h, or before it. Linus -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
