2008/7/9 Junio C Hamano <gitster@xxxxxxxxx>: > Robert Shearman <robertshearman@xxxxxxxxx> writes: >> diff --git a/Documentation/git-imap-send.txt b/Documentation/git-imap-send.txt >> index b3d8da3..e4a5873 100644 >> --- a/Documentation/git-imap-send.txt >> +++ b/Documentation/git-imap-send.txt >> @@ -37,10 +37,11 @@ configuration file (shown with examples): >> Tunnel = "ssh -q user@xxxxxxxxxx /usr/bin/imapd ./Maildir 2> /dev/null" >> >> [imap] >> - Host = imap.server.com >> + Host = imaps://imap.example.com >> User = bob >> Pass = pwd >> - Port = 143 >> + Port = 993 >> + sslverify = false >> .......................... > > Don't we also want to keep a vanilla configuration in the example, or is > imaps the norm and unencrypted imap is exception these days? Good point. I'll fix the documentation to use imap:// instead of imaps:// and not change the port number. However, I'm not sure the examples should be telling the user what they should do, but rather what they can do. > Don't we need to support custom certificates, keys and CAs, just like our > code that supports https does, by honoring GIT_SSL_* environment variables > and configuration file entries? Yes, eventually we will want that support in imap-send too. It should be fairly trivial to do, although testing will be more difficult. > The patch itself looks fairly clean, and > I'd like to queue this for wider testing, initially even without GIT_SSL_* > support. But I'd like to see any patch with substantial amount of changes > properly signed off. Great. I'll resend the series later with changes from the comments I've received and properly signed-off. -- Rob Shearman -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
