On Wed, Jul 09, 2008 at 01:15:43AM +0000, Junio C Hamano wrote: > Pierre Habouzit <madcoder@xxxxxxxxxx> writes: > > > If you set this for a given flag, and the flag appears without a value on > > the command line, then the `defval' is used to fake a new argument. > > > > Note that this flag is meaningless in presence of OPTARG or NOARG flags. > > (in the current implementation it will be ignored, but don't rely on it). > > > > Signed-off-by: Pierre Habouzit <madcoder@xxxxxxxxxx> > > --- > > > > > (3) inspired from (1) and (2), have a flag for options that says > > > "I do take an argument, but if I'm the last option on the > > > command line, please fake this argument for me. > > > > > > I really like (3) more FWIW as it doesn't generate ambiguous > > > parsers like (2) would, and it's not horrible like (1). And cherry > > > on top it's pretty trivial to implement I think. > > Yeah, I do not particularly want a major rewrite that only introduces > possible ambiguity to the option parser (even though arguably it would add > to the usability very much, just like we accept revs and paths when > unambiguous), so I think this is a reasonable compromise. > > It feels more like LASTARG_DEFAULT but that is bikeshedding ;-) I absolutely don't like this FAKELASTARG name, so really, use what you like. > But I see one thinko (fix below) and another issue I am not sure what the > best fix would be. Like I said it was just a draft, I did not test the new feature, so I'm not really surprised it's partly broken ;) -- ·O· Pierre Habouzit ··O madcoder@xxxxxxxxxx OOO http://www.madism.org
Attachment:
pgpfL0XzOj7z0.pgp
Description: PGP signature
