Junio C Hamano wrote: > If we were to do anything, don't we rather want to fail everything upfront > when the tests are run by root [because it's crazy]? I think that unless/until someone wants to submit a patch that makes the tests fail upfront, we should use Fernando's patch; it's an improvement over the current situation. I'm actually not entirely sure if skipping or failing everything if the tests are run as root is a good idea -- for instance, neither skipping nor failing seems appropriate for Gentoo's root-in-a-sandbox situation. Jakub Narebski wrote: > "Fernando J. Pereda" <ferdy@xxxxxxxxxx> writes: >> + test_expect_success '[...], skipping test' : >> + test_done >> + exit > > Yet another place that would profit from test_skip in test-lib.sh... *nods* I'd rather name it 'test_skip_all' for clarity though, at least if it contains "test_done; exit". (I'm not volunteering to send a patch, FTR...) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
