On Mon, Jul 07, 2008 at 12:54:41PM -0700, Junio C Hamano wrote: > Mike Hommey <mh@xxxxxxxxxxxx> writes: > > > On Mon, Jul 07, 2008 at 09:02:37PM +0200, Mike Hommey wrote: > >> http-push test has been broken by 4a7aaccd adding a space character > >> in the place where the test is being run. > >> --- > >> > >> Note that the 4th test doesn't pass because of the new git clone, that > >> creates the clone with packed-refs instead of refs/heads/master that > >> push is requiring. But this also means push was already broken with > >> repositories with packed-refs. > > > > Actually, the 3rd is failing too, but fails to report an error because > > git push returns no error code in cases where it says: > > No refs in common and none specified; doing nothing. > > Ok, when you are done checking, care to send in a replacement patch with > failing one marked with test_expect_failure? Shouldn't that be two different patches ? One to fix the spaces problem and one to handle the fact that builtin-clone broke the tests ? Mike -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
