The stat string was only initialized if the ref was local, but was
always used in a printf. This meant that whatever data was on the
stack got printed. In the case of "branch -av", this was probably the
tracking information of the last local branch. If the case of "branch
-rv", this was "@???" in my case.
Signed-off-by: Brian Gernhardt <benji@xxxxxxxxxxxxxxxxxx>
---
After looking through the second get of changes I pulled, I tried this:
$ git branch -av
* master 3195299 [ahead 1] Make rebase save ORIG_HEAD if changing current branch
origin/HEAD 08b51f5 [ahead 1] Merge branch 'qq/maint'
origin/gitk-for-paulus 7d8856d [ahead 1] gitk: Update German translation.
Huh. That doesn't look right... Let's try just showing the remotes:
$ git branch -rv
origin/HEAD 08b51f5 @???Merge branch 'qq/maint'
origin/gitk-for-paulus 7d8856d @???gitk: Update German translation.
That's definately not good.
I guess that other people either have a compiler that is more careful about
clearing stack variables, or don't use "branch -v".
builtin-branch.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/builtin-branch.c b/builtin-branch.c
index e9423d1..470c59f 100644
--- a/builtin-branch.c
+++ b/builtin-branch.c
@@ -327,7 +327,7 @@ static void print_ref_item(struct ref_item *item, int maxwidth, int verbose,
if (verbose) {
struct strbuf subject;
const char *sub = " **** invalid ref ****";
- char stat[128];
+ char stat[128] = "";
strbuf_init(&subject, 0);
--
1.5.6.2.336.g3195
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
