Le samedi 5 juillet 2008, Brian Hetro a écrit :
> These patches are related to the git_config_string "janitorial" work.
Your patches look good to me.
By the way, your first patch in the series seems to fix a bug:
> int git_commit_config(const char *k, const char *v, void *cb)
> {
> - if (!strcmp(k, "commit.template")) {
> - if (!v)
> - return config_error_nonbool(v);
It should have been:
- return config_error_nonbool(k);
> - template_file = xstrdup(v);
> - return 0;
> - }
> + if (!strcmp(k, "commit.template"))
> + return git_config_string(&template_file, k, v);
There is the same bug in "wt-status.c". I will send a fix for this one.
So (for the patch series):
Tested-by: Christian Couder <chriscool@xxxxxxxxxxxxx>
Thanks,
Christian.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
