> > Yeah, it is simply a bad taste to use helper in builtin-A from builtin-B. > More library-ish files such as revision.c are better home for utility > functions to be shared between builtins and commands. > > Here is what I queued. > Thank you. > By the way did you compile test your fix before sending? > I ran make and test, but I didn't notice the warnings that prompted the question. I also forgot to re-check it after re-working the commits to put everything in order. > -- >8 -- Thank you again for your help and patience in dealing with my multiple failed attempts to get this right. Adam -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
