Steffen Prohaska <prohaska@xxxxxx> writes:
> If htmldir (in the Makefile) is a relative path, this path will be
> interpreted relative to git_exec_path. This can be used to create an
> installation that can be moved to a different directory without
> re-compiling. The Windows installer (msysgit) is an example for such
> a setup.
> ...
> + const char* html_path = GIT_HTML_PATH;
Style. Asterisk sticks to the variable, not type.
> + if (!is_absolute_path(html_path)) {
> + struct strbuf d = STRBUF_INIT;
> + strbuf_addf(&d, "%s/%s", git_exec_path(), html_path);
> + html_path = strbuf_detach(&d, NULL);
> + }
I've seen similar "if $this (which is usually an absolute) is relative, it
is taken as relative to git_exec_path" solution employed elsewhere in the
MinGW series, and I think it makes sense, even though initially I thought
it was somewhat hacky.
Could you check if there are copy-and-pasted duplicated code you can
factor out before continuing this direction? I suspect templates and
etc/gitconfig are specified in similar fashion, and it would probably be
easier to maintain if you define once:
char *system_path(const char *specified)
{
if (is_absolute_path(specified))
return specified;
... strbuf dance ...
return strbuf_detach(...);
}
and use it like this:
const char *html_path = system_path(GIT_HTML_PATH);
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
