Re: [PATCH 11/12] verify_path(): do not allow absolute paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Jul 2, 2008, at 6:15 PM, Johannes Schindelin wrote:

Hi,

On Wed, 2 Jul 2008, Junio C Hamano wrote:

Steffen Prohaska <prohaska@xxxxxx> writes:

Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
Signed-off-by: Steffen Prohaska <prohaska@xxxxxx>

No commit log message?  Justification?

Justification: adding absolute paths was not caught properly on Windows,
and this was the easiest patch.

However, IIRC, in the meantime we are nice to the user, and allow absolute paths (which we turn into a relative path, or error out if it is not under
the current working directory).

Steffen, can you revert the patch and verify that my memory does not fail
me?

Is

   git add /c/msysgit/git/read-cache.c

an appropriate test?

It fails with

   error: 'c:/msysgit/git/read-cache.c' is outside repository

no matter if the commit is reverted or not.

	Steffen


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux