Thomas Rast <trast@xxxxxxxxxxxxxxx> writes: > The cmd_show loop resolves tags by showing them, then pointing the > object to the 'tagged' member. However, this object is not fully > initialized; it only contains the SHA1. (This resulted in a segfault > if there were two levels of tags.) We apply parse_object to get a > full object. > > Noticed by Kalle Olavi Niemitalo on IRC. > > Signed-off-by: Thomas Rast <trast@xxxxxxxxxxxxxxx> > --- > > I'm not 100% sure this is the right fix; I just had a quick stab at > the code, made a fix and tested it. It probably leaks memory too, not > sure if this is a problem. The code looks good. It should not have been accessing the object without making sure it has been parsed. And it's not a leak. Once you instantiate "struct object" derived class, we hold onto it (at least to its skeleton). Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
