On Tue, Jul 01, 2008 at 12:27:48AM -0700, Junio C Hamano <gitster@xxxxxxxxx> wrote: > I'll queue the fixed-up result in 'pu', but I have to tend to other topics > before I can actually publish. Together with the fix to "head_invalid" > confusion I mentioned in another message squashed in to this commit, all > the tests now finally seem to pass on the topic branch. > > Oh, by the way, you sent this and the previous round without marking them > as RFC nor WIP, even though they obviously did not even pass the test > suite. For example, without the head_invalid fix, anything that runs > merge on detached head, most notably "git rebase -i", would not work at > all. Thanks for pointing that out. I remember I used to run 'make test' before sending a patch, but that took a lot of time and then I used to run only t*merge*.sh, which - it turns out - was a bad idea, since I haven't noticed breaking t3404. I'm now running a full 'make test' before I send the patch.
Attachment:
pgp7w0Q3H06zY.pgp
Description: PGP signature
