Hi, On Sun, 29 Jun 2008, Junio C Hamano wrote: > Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > > > On Sun, 29 Jun 2008, Daniel Barkalow wrote: > > > >> Did we even make a commitment on whether: > >> > >> GIT_CONFIG=foo git clone bar > >> > >> must ignore the environment variable, or simply doesn't necessarily > >> obey it? > > > > I'd rather strongly argue that no matter what is the answer to this > > question, we _HAVE TO_ unsetenv() GIT_CONFIG at some stage, otherwise > > no .git/config will be written. > > > > So, this is a NACK on your patch. > > True. We are creating the config file for the new repository, so the > initial setenv() would make sense. We _could_ save away end user's > GIT_CONFIG and restore it where you unsetenv() in your patch, No. That would break again, since then, - $HOME/.gitconfig would be ignored again (which was the single issue my patch addressed), and - the remote information would be written into the wrong file. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
