Eric Wong <normalperson@xxxxxxxx> wrote: > Avery Pennarun <apenwarr@xxxxxxxxx> wrote: > > Without this patch, git-svn failed with the error: > > config --get svn-remote.D2007.Win32.url: command returned error: 1 > > > > ...upon trying to automatically follow a link from a child branch back to > > its parent branch D2007_Win32 (note the underscore, not dot, separating the > > two words). > > > > Note that I have each of my branches defined (by hand) as separate > > svn-remote entries in .git/config since my svn repository layout is > > nonstandard. > > > > Signed-off-by: Avery Pennarun <apenwarr@xxxxxxxxx> > > Thanks, > > Acked-by: Eric Wong <normalperson@xxxxxxxx> > > > --- > > I'm not sure why sanitize_remote_name is so picky about allowed characters, > > but underscore should certainly be allowed. I'm worried that this has > > revealed a more serious problem, since presumably sanitizing the name > > shouldn't break anything in any case. > > Weird. It looks like a stupid bug on my part. I'm surprised > it took this long to find, since underscore is pretty common... Wait, nevermind, this is for remotes, not remote *branches*. Umm... are underscores now allowed in git config files? -- Eric Wong -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
