Ocular review looks fine, but nevertheless some tests break. -- robin org.spearce.jgit--All-Tests org.spearce.jgit.lib.PackIndexV2Test testIteratorMethodsContract(org.spearce.jgit.lib.PackIndexV2Test) java.io.IOException: Unreadable pack index: /home/me/SW/EGIT.contrib/org.spearce.jgit.test/tst/pack-34be9032ac282b11fa9babdc2b2a93ca996c9c2f.idxV2 at org.spearce.jgit.lib.PackIndex.open(PackIndex.java:95) at org.spearce.jgit.lib.PackIndexTest.setUp(PackIndexTest.java:54) at junit.framework.TestCase.runBare(TestCase.java:128) at junit.framework.TestResult$1.protect(TestResult.java:106) at junit.framework.TestResult.runProtected(TestResult.java:124) at junit.framework.TestResult.run(TestResult.java:109) at junit.framework.TestCase.run(TestCase.java:120) at junit.framework.TestSuite.runTest(TestSuite.java:230) at junit.framework.TestSuite.run(TestSuite.java:225) at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java:130) at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:673) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386) at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:196) Caused by: java.io.EOFException: Short read of block. at org.spearce.jgit.util.NB.readFully(NB.java:67) at org.spearce.jgit.lib.PackIndexV1.<init>(PackIndexV1.java:75) at org.spearce.jgit.lib.PackIndex.open(PackIndex.java:91) ... 14 more testIteratorReturnedValues1(org.spearce.jgit.lib.PackIndexV2Test) same trace testCompareEntriesOffsetsWithFindOffsets(org.spearce.jgit.lib.PackIndexV2Test) same trace testIteratorReturnedValues2(org.spearce.jgit.lib.PackIndexV2Test) same trace Together with Marek's packwrite patches the list gets even longer (his patches alone are "green"). I'm not including them here. -- robin -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html