On Tue, 24 Jun 2008, Teemu Likonen wrote: > Nicolas Pitre wrote (2008-06-24 15:34 -0400): > > > I'm trying to reproduce your segfault with current master > > (v1.5.6-56-g29b0d01) but I just can't. > > > > Can you provide a gdb backtrace of the segfault? > > Let's hope I'm doing this right. Just installed gdb for the first time. > I started with "gdb git" and then typed "run clone http://...";. > Eventually it gave this: Excellent! The problem is probably fixed with this: diff --git a/sha1_file.c b/sha1_file.c index a92f023..b7d1a82 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -844,6 +844,8 @@ struct packed_git *parse_pack_index(unsigned char *sha1) strcpy(p->pack_name, path); p->pack_size = 0; + p->num_bad_objects = 0; + p->bad_object_sha1 = NULL; p->next = NULL; p->windows = NULL; p->pack_fd = -1; Could you confirm it? However I just don't like the fact that pack structures are allocated and initialized in two places, which makes it error prone as demonstrated here. So I'll cook up a better patch that fixes the duplication issue. Nicolas -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
