On Mon, Jun 23, 2008 at 01:12:28PM -0700, Linus Torvalds wrote: > > in your options table. And if setup_revisions takes options that affect > > things that _aren't_ in that struct, then they probably ought to be. > > The world isn't like "it ought to be". It is like it is. > > If you keep on dreaming about how things "ought to be", you'll never > confront the things as they are. The fact is, turning the existing very > simple argument parsers into using "parse_options()" is just _hard_. > > Then you say that it all "ought to be" in those options already. Did you even read my mail? All I said "ought to be" is that revision options "ought to be" affecting things in the struct. As in, when I convert this to parse_options, if there are any cases which don't fall into that pattern then I "ought to be" able to convert them as part of the code cleanup. And looking over the revision parsing code, it looks like everything falls into that case already. So if you have something FACTUAL to say that contradicts that point, by all means do it. You might save me some work if you find a showstopper in my approach. > Sure. Do we have some invisible sky wizard to make it so? Well, given that I already said I would work on it, I guess that makes me the sky wizard. Bow down before my wizardly might! That being said, it looks like Pierre is working on a slightly different approach, and I am happy to sit back and see how that pans out for now. So perhaps he is the sky wizard. > I tried to do just _one_ program. Trust me, I'm not going to even bother > trying to do another unless parse_options() is made more palatable to do > in small pieces. Maybe we are fundamentally talking across each other. I'm not talking about some specifics for converting a bunch of programs, or some problems with parse_options. I'm suggesting that the main "two stage" option parsing generally has the revision parsing as the "second stage". Converting that one thing to parse_options will help with converting many programs (e.g., a failed conversion of shortlog that others and I worked on). You seem to have a bunch of _other_ problems with parse_options. And that is fine, but they have nothing whatsoever to do with anything I've said. So don't "sky wizard" _me_ about those problems. ;P -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
