Re: [RFC] Re: Convert 'git blame' to parse_options()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 23, 2008 at 06:04:48PM +0100, Johannes Schindelin wrote:

> > > Thinking about the recursive approach again, I came up with this POC:
> > 
> > "recursive" is pointless.
> 
> Nope, it is not.

AIUI, one difference between your approach and Pierre's is that he is
suggesting (and I have suggested this in the past, too) a big
DIFF_OPTIONS macro that you stick in the options table for each command.
Whereas you are allowing for subtables accessible via pointers.

Your approach should yield a much leaner text size (which was what
started this whole thing) since we don't end up with the same repeated
subsets of options tables, and in particular the one-liner help text
(yes, compilers can sometimes point share the string literal components,
but most of our options tables are declared as static, so unless the
linker is very smart, I think we will end up with duplicates).

> Heck, we could just as easily introduce PARSE_OPT_IGNORE_UNKNOWN.

We could even send it to the list with message-id

  http://mid.gmane.org/1213758236-979-2-git-send-email-shawn.bohrer@xxxxxxxxx

and then Junio and I could complain that the concept is broken.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux