Hi, On Fri, 20 Jun 2008, Stephan Beyer wrote: > This patch adds some extra checks into some > test cases and changes "! git ..." into > "test_must_fail git". I think your oneline should read "t3404: be more anal". > diff --git a/t/t3404-rebase-interactive.sh b/t/t3404-rebase-interactive.sh > index e6f3fad..daba5fd 100755 > --- a/t/t3404-rebase-interactive.sh > +++ b/t/t3404-rebase-interactive.sh > @@ -107,7 +107,8 @@ chmod a+x fake-editor.sh > > test_expect_success 'no changes are a nop' ' > git rebase -i F && > - test $(git rev-parse I) = $(git rev-parse HEAD) > + test $(git rev-parse I) = $(git rev-parse HEAD) && > + test "$(git symbolic-ref -q HEAD)" = "refs/heads/branch2" > ' You could have saved some diff-screen-estate by putting the extra check _before_ the original one. Other than that, I think this patch is fine. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
