Adam Simpkins <adam@xxxxxxxxxxxxxxxx> writes: > On Thu, Jun 19, 2008 at 12:16:11PM -0700, Junio C Hamano wrote: >> しらいしななこ <nanako3@xxxxxxxxxxx> writes: > ... >> > +/* Internal API */ >> > + ... >> > +static int graph_next_line(struct git_graph *graph, struct strbuf *sb); >> > +static void graph_padding_line(struct git_graph *graph, struct strbuf *sb); >> > +static void graph_show_strbuf(struct git_graph *graph, struct strbuf const *sb); >> >> I think these are probably fine, not in the sense that nobody calls these >> functions _right now_ but in the sense that I do not foresee a calling >> sequence outside the graph.c internal that needs to call these directly, >> instead of calling graph_show_*() functions that use these. > > Documentation/technical/api-history-graph.txt should also be updated > to remove the discussion of these functions if they are no longer > publicly exposed. Actually, I was expecting (not necessarily _hoping_) you to defend these public API by providing examples that illustrates when calling these from outside graph API implementation could be useful. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
