Re: [PATCH] t7502-commit.sh: test_must_fail doesn't work with inline environment variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano wrote:

> A Subshell?
> 
> @@ -212,6 +212,7 @@ test_expect_success 'do not fire
>  	# Must fail due to conflict
>  	test_must_fail git cherry-pick -n master &&
>  	echo "editor not started" >.git/result &&
> -	test_must_fail GIT_EDITOR="$(pwd)/.git/FAKE_EDITOR" git commit &&
> +	( GIT_EDITOR="$(pwd)/.git/FAKE_EDITOR" && export GIT_EDITOR &&
> +	  test_must_fail git commit ) &&
>  	test "$(cat .git/result)" = "editor not started"
>  '

That works and it's better.

-brandon
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux